Skip to content

Develop #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NureSviderskyiOleksandr wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #6228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29e55c8
task complete
NureSviderskyiOleksandr May 21, 2026
c12ac65
task complete
NureSviderskyiOleksandr May 21, 2026
f0bcbb4
task complete
NureSviderskyiOleksandr May 21, 2026
7535b5b
fix margins
NureSviderskyiOleksandr May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Create an HTML page with a catalog. Develop semantic page structure as shown on
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- nav links color is not `black` anymore (nav links should have `#060b35` color)
- add the class `is-active` to the first link (`Apple`) in the navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use the grid for cards with different numbers of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -33,8 +33,8 @@ This is possible because [we use the Parcel library](https://en.parceljs.org/scs
## Checklist

❗️ Replace `<your_account>` with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
- [DEMO LINK](https://NureSviderskyiOleksandr.github.io/layout_catalog/)
- [TEST REPORT LINK](https://NureSviderskyiOleksandr.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
308 changes: 307 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,312 @@
</head>

<body>
<h1>Catalog</h1>
<header class="menu-container">
Comment on lines 23 to +25
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition property is placed inside :hover instead of on the base .card element. While this works, placing it on the base element is the proper pattern for smooth transitions

<ul class="nav-list">
<li>
<a
Comment on lines 22 to +28
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nav link color should be #060b35 instead of #000 according to requirements

href="#"
class="nav-list__nav-link"
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded color #34568b should be extracted to a SCSS variable. According to checklist item #2, special colors must be put to variables.

>
<img
class="logo"
src="images/logo.png"
alt="Moyo-logo"
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded color #fff should be extracted to a SCSS variable. According to checklist item #2, special colors must be put to variables.

/>
</a>
</li>
</ul>
<nav>
<ul class="nav-list">
<li>
<a
class="nav-list__nav-link is-active"
href="#"
>
Apple
</a>
</li>
<li>
<a
class="nav-list__nav-link"
href="#"
>
Samsung
</a>
</li>
<li>
<a
class="nav-list__nav-link"
href="#"
>
Smartphones
</a>
</li>
<li>
<a
class="nav-list__nav-link"
href="#"
data-qa="nav-hover"
>
Laptops & Computers
</a>
</li>
<li>
<a
class="nav-list__nav-link"
href="#"
>
Gadgets
</a>
</li>
<li>
<a
class="nav-list__nav-link"
href="#"
>
Tablets
</a>
</li>
<li>
<a
class="nav-list__nav-link"
href="#"
>
Photo
</a>
</li>
<li>
<a
class="nav-list__nav-link"
href="#"
>
Video
</a>
</li>
</ul>
</nav>
</header>
<main class="container">
<section
data-qa="card"
class="card"
>
<div class="card__image"></div>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
data-qa="card-hover"
class="card__button"
>
Buy
</a>
</section>
<section class="card">
<div class="card__image"></div>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
Buy
</a>
</section>
<section class="card">
<div class="card__image"></div>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
Buy
</a>
</section>
<section class="card">
<div class="card__image"></div>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
Buy
</a>
</section>
<section class="card">
<div class="card__image"></div>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
Buy
</a>
</section>
<section class="card">
<div class="card__image"></div>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
Buy
</a>
</section>
<section class="card">
<div class="card__image"></div>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
Buy
</a>
</section>
<section class="card">
<div class="card__image"></div>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price-label">Price:</p>
<p class="card__price-value">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
Buy
</a>
</section>
</main>
</body>
</html>
Loading
Loading