add task solution#6230
Conversation
Ruslan95fs
commented
May 23, 2026
Ruslan95fs
commented
- DEMO LINK
- TEST REPORT LINK
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation meets all core functional requirements and is functionally complete. The BEM methodology issues identified are style and methodology improvements rather than functional blockers, so the code can be approved as is.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| } | ||
|
|
||
| &__rating { |
There was a problem hiding this comment.
This global a:hover selector is outside the BEM block structure and can affect all anchor elements in the document. Consider moving this hover behavior inside the .nav__link block as &:hover to maintain proper BEM methodology and avoid unintended side effects on other links.
| <!-- #region head --> | ||
| <!doctype html> |
There was a problem hiding this comment.
Redundant box-sizing: border-box declaration - this property is already set globally in index.scss for all elements
|
|
||
| &.is-active::after { | ||
| content: ''; | ||
| position: absolute; |
There was a problem hiding this comment.
Hardcoded color #34568b should be moved to a variable for consistency with other colors.
| color: #00acdc; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This global selector a:hover violates BEM methodology. BEM requires all styles to be scoped within block classes. Consider using .nav__link:hover instead, or add :not(.is-active) to exclude the active state from hover color change.
| $width-card: 200px; | ||
| $radius-card: 5px; |
There was a problem hiding this comment.
Redundant box-sizing: border-box - this property is already set globally in index.scss for all elements via the * selector. This declaration in card.scss is unnecessary.
2 participants
