add task solution#6234
Conversation
znaumova
commented
May 27, 2026
znaumova
commented
- DEMO LINK
- TEST REPORT LINK
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation has critical issues: data-qa attributes are applied to all cards instead of just the first one, card hover styles are duplicated across files causing visual and functional problems, a required color variable is missing, and visual regression tests are failing due to styling mismatches.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" |
There was a problem hiding this comment.
The data-qa="card" attribute is present on ALL cards, but according to requirements it should only be on the FIRST card. Remove this attribute from all cards except the first one (lines 155, 192, 229, 266, 303, 340, 377).
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__image"></div> | ||
|
|
||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <p class="card__code">Product code: 195434</p> | ||
|
|
||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <span class="card__reviews">Reviews: 5</span> | ||
| </div> | ||
|
|
||
| <div class="card__price-block"> | ||
| <span class="card__price-label">Price:</span> | ||
| <span class="card__price">$2,199</span> | ||
| </div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__buy" | ||
| data-qa="card-hover" |
There was a problem hiding this comment.
The data-qa="card-hover" attribute is present on ALL Buy links, but according to requirements it should only be on the FIRST card's Buy link. Remove this attribute from all cards except the first one (lines 185, 222, 259, 296, 333, 370, 407).
| class="nav__link" | ||
| > | ||
| Video | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| </header> | ||
|
|
||
| <main class="catalog"> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > |
There was a problem hiding this comment.
The .card hover rules here (lines 109-119) apply to ALL cards and will cause the scale transform to affect every card on hover. According to requirements, only the FIRST card should have hover effects. Consider using :first-of-type:hover or moving hover-specific styles to only target the first card, or remove this block entirely if card.scss is meant to handle card styling.
|
|
||
| .card { | ||
| transition: transform 300ms; | ||
|
|
||
| &:hover { | ||
| transform: scale(1.2); | ||
| z-index: 1; | ||
| background-color: #fff; | ||
| color: #00acdc; | ||
| } | ||
|
|
||
| &:hover &__title { | ||
| color: #34568b; | ||
| } |
There was a problem hiding this comment.
The .card block is defined here again after already being defined in card.scss. According to BEM methodology, each block should be defined in its own dedicated file. The hover effects (&:hover, &:hover &__title) are duplicates of styles already in card.scss. Consider moving all card-related styles to card.scss and removing this duplicate definition.
|
|
||
| &:hover { | ||
| transform: scale(1.2); | ||
| z-index: 1; | ||
| background-color: #fff; | ||
| color: #00acdc; |
There was a problem hiding this comment.
The color: #00acdc on card hover will change ALL text inside the card to blue, including the title and price text. This conflicts with the button's own hover styles in card.scss which set color: $accent-color (blue) on a white background. The button will have blue text on blue background when the card is hovered. Consider removing this line or ensuring it only affects intended elements.
| color: #00acdc; | ||
| } | ||
|
|
||
| &:hover &__title { |
There was a problem hiding this comment.
Hardcoded color #34568b should use a variable for consistency with the design system and checklist requirement #2.
| $text-main: #060b35; | ||
| $text-secondary: #616070; | ||
| $background: #fff; | ||
| $accent-color: #00acdc; | ||
| $gray-elements: #f3f3f3; |
There was a problem hiding this comment.
The color #34568b used for card title hover in index.scss (line 117) is not defined as a variable. According to checklist item #2, all special colors should be put to variables. Add: $card-title-hover: #34568b;
3 participants
