-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Solution #6237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Solution #6237
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,22 +6,376 @@ | |
| name="viewport" | ||
| content="width=device-width, initial-scale=1.0" | ||
| /> | ||
| <title>Catalog</title> | ||
| <title>MOYO Catalog</title> | ||
|
|
||
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.googleapis.com" | ||
| /> | ||
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.gstatic.com" | ||
| crossorigin="anonymous" | ||
| /> | ||
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700&display=swap" | ||
| rel="stylesheet" | ||
| /> | ||
| <link | ||
| rel="stylesheet" | ||
| href="styles/index.scss" | ||
| href="./styles/index.scss" | ||
| /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <h1>Catalog</h1> | ||
| <header class="header"> | ||
| <a | ||
| href="#" | ||
| class="header__logo-link" | ||
| > | ||
| <img | ||
| src="./images/logo.png" | ||
| alt="MOYO logo" | ||
| class="header__logo" | ||
| /> | ||
| </a> | ||
|
|
||
| <nav | ||
| class="nav" | ||
| aria-label="Main navigation" | ||
| > | ||
| <ul class="nav__list"> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link is-active" | ||
| > | ||
| Apple | ||
| </a> | ||
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link" | ||
| > | ||
| Samsung | ||
| </a> | ||
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link" | ||
| > | ||
| Smartphones | ||
| </a> | ||
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link" | ||
| data-qa="nav-hover" | ||
| > | ||
| Laptops & Computers | ||
| </a> | ||
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link" | ||
| > | ||
| Gadgets | ||
| </a> | ||
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link" | ||
| > | ||
| Tablets | ||
| </a> | ||
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link" | ||
| > | ||
| Photo | ||
| </a> | ||
| </li> | ||
|
Comment on lines
+100
to
+103
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The card scales on hover but CSS transform doesn't remove the element from document flow. This means the scaled card will visually overlap with neighboring cards. The requirement states 'neighboring cards should not be affected' - consider using transform with proper positioning to prevent overlap. |
||
| <li class="nav__item"> | ||
| <a | ||
| href="#" | ||
| class="nav__link" | ||
| > | ||
| Video | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </nav> | ||
| </header> | ||
|
|
||
| <main class="catalog"> | ||
| <article | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <img | ||
| src="./images/imac.jpeg" | ||
| alt="APPLE A1419 iMac 27 Retina" | ||
| class="card__image" | ||
| /> | ||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
| <p class="card__code">Product code: 195434</p> | ||
| <div class="card__review"> | ||
| <div | ||
| class="stars stars--4" | ||
| aria-label="Rating: 4 out of 5" | ||
| > | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| </div> | ||
| <p class="card__reviews">Reviews: 5</p> | ||
| </div> | ||
| <div class="card__price"> | ||
| <p class="card__price-text">Price:</p> | ||
| <p class="card__price-value">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" | ||
| class="card__button" | ||
| data-qa="card-hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </article> | ||
|
|
||
| <article class="card"> | ||
| <img | ||
| src="./images/imac.jpeg" | ||
| alt="APPLE A1419 iMac 27 Retina" | ||
| class="card__image" | ||
| /> | ||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
| <p class="card__code">Product code: 195434</p> | ||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| </div> | ||
| <p class="card__reviews">Reviews: 5</p> | ||
| </div> | ||
| <div class="card__price"> | ||
| <p class="card__price-text">Price:</p> | ||
| <p class="card__price-value">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" | ||
| class="card__button" | ||
| > | ||
| Buy | ||
| </a> | ||
| </article> | ||
|
|
||
| <article class="card"> | ||
| <img | ||
| src="./images/imac.jpeg" | ||
| alt="APPLE A1419 iMac 27 Retina" | ||
| class="card__image" | ||
| /> | ||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
| <p class="card__code">Product code: 195434</p> | ||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| </div> | ||
| <p class="card__reviews">Reviews: 5</p> | ||
| </div> | ||
| <div class="card__price"> | ||
| <p class="card__price-text">Price:</p> | ||
| <p class="card__price-value">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" | ||
| class="card__button" | ||
| > | ||
| Buy | ||
| </a> | ||
| </article> | ||
|
|
||
| <article class="card"> | ||
| <img | ||
| src="./images/imac.jpeg" | ||
| alt="APPLE A1419 iMac 27 Retina" | ||
| class="card__image" | ||
| /> | ||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
| <p class="card__code">Product code: 195434</p> | ||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| </div> | ||
| <p class="card__reviews">Reviews: 5</p> | ||
| </div> | ||
| <div class="card__price"> | ||
| <p class="card__price-text">Price:</p> | ||
| <p class="card__price-value">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" | ||
| class="card__button" | ||
| > | ||
| Buy | ||
| </a> | ||
| </article> | ||
|
|
||
| <article class="card"> | ||
| <img | ||
| src="./images/imac.jpeg" | ||
| alt="APPLE A1419 iMac 27 Retina" | ||
| class="card__image" | ||
| /> | ||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
| <p class="card__code">Product code: 195434</p> | ||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| </div> | ||
| <p class="card__reviews">Reviews: 5</p> | ||
| </div> | ||
| <div class="card__price"> | ||
| <p class="card__price-text">Price:</p> | ||
| <p class="card__price-value">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" | ||
| class="card__button" | ||
| > | ||
| Buy | ||
| </a> | ||
| </article> | ||
|
|
||
| <article class="card"> | ||
| <img | ||
| src="./images/imac.jpeg" | ||
| alt="APPLE A1419 iMac 27 Retina" | ||
| class="card__image" | ||
| /> | ||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
| <p class="card__code">Product code: 195434</p> | ||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| </div> | ||
| <p class="card__reviews">Reviews: 5</p> | ||
| </div> | ||
| <div class="card__price"> | ||
| <p class="card__price-text">Price:</p> | ||
| <p class="card__price-value">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" | ||
| class="card__button" | ||
| > | ||
| Buy | ||
| </a> | ||
| </article> | ||
|
|
||
| <article class="card"> | ||
| <img | ||
| src="./images/imac.jpeg" | ||
| alt="APPLE A1419 iMac 27 Retina" | ||
| class="card__image" | ||
| /> | ||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
| <p class="card__code">Product code: 195434</p> | ||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| </div> | ||
| <p class="card__reviews">Reviews: 5</p> | ||
| </div> | ||
| <div class="card__price"> | ||
| <p class="card__price-text">Price:</p> | ||
| <p class="card__price-value">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" | ||
| class="card__button" | ||
| > | ||
| Buy | ||
| </a> | ||
| </article> | ||
|
|
||
| <article class="card"> | ||
| <img | ||
| src="./images/imac.jpeg" | ||
| alt="APPLE A1419 iMac 27 Retina" | ||
| class="card__image" | ||
| /> | ||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
| <p class="card__code">Product code: 195434</p> | ||
| <div class="card__review"> | ||
| <div class="stars stars--4"> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| <span class="stars__star"></span> | ||
| </div> | ||
| <p class="card__reviews">Reviews: 5</p> | ||
| </div> | ||
| <div class="card__price"> | ||
| <p class="card__price-text">Price:</p> | ||
| <p class="card__price-value">$2,199</p> | ||
| </div> | ||
| <a | ||
| href="#" | ||
| class="card__button" | ||
| > | ||
| Buy | ||
| </a> | ||
| </article> | ||
| </main> | ||
| </body> | ||
| </html> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gap values are hardcoded (46px 48px) instead of using variables. According to checklist item #2, repeated sizes and special colors must be put to variables. The variables.scss file should define these gap values.