implement responsive grid layout for cards#6244
Conversation
hanna-moskalenko
commented
Jun 1, 2026
- DEMO LINK
- TEST REPORT LINK
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is missing two critical requirements that must be addressed before approval:
-
Missing
data-qa="card-hover"attribute on the first card's BUY button (around line 159 insrc/index.html). The task explicitly requires this attribute on theBuylink inside the first card for test automation purposes. Without it, automated tests won't be able to locate this element. -
Incorrect class name on card titles - You're using
card__chapterinstead ofcard__title. The hover effect styles in your SCSS use.card:hover .card__titleselector, but the HTML has the wrong class, so the hover color change won't work.
What you need to fix:
- Add
data-qa="card-hover"to the anchor element with classcard__buttonin the first card - Change the title elements from
card__chaptertocard__title(both in HTML and any references in SCSS)
The visual regression (1.09% difference) is minor and likely a consequence of the above issues - it should resolve once these are corrected.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| </div> | ||
| </div> | ||
|
|
||
| <a class="card__button">BUY</a> |
There was a problem hiding this comment.
Missing required data-qa="card-hover" attribute on the BUY button of the first card. According to the requirements, this attribute must be added to the link Buy inside the first card for testing purposes.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation has one critical issue that needs fixing: the cards container uses <div class="container"> instead of the required <main> tag per the task specification [CHECKLIST ITEM: "use <main> tag for cards container"]. This is a semantic HTML requirement that must be addressed. Additionally, there are 2 visual regression test failures with a 1.09% difference from reference screenshots (threshold: 1%) - while this appears to be a minor CSS variance, you'll want to verify card-related styles haven't unintentionally changed. All other requirements are met: BEM structure, SCSS variables, responsive breakpoints, hover transitions, and all required data-qa attributes are correctly placed.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
brespect
left a comment
There was a problem hiding this comment.
Good progress, but your DEMO LINK is broken