Skip to content

Add catalog page#6246

Open
serezatkacik8-boop wants to merge 4 commits into
mate-academy:masterfrom
serezatkacik8-boop:catalog-page
Open

Add catalog page#6246
serezatkacik8-boop wants to merge 4 commits into
mate-academy:masterfrom
serezatkacik8-boop:catalog-page

Conversation

@serezatkacik8-boop
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets most requirements including BEM methodology, SCSS structure, responsive grid layout, and proper hover effects. However, there's a critical checklist violation that must be addressed. The task checklist explicitly requires "Repeated sizes and special colors are put to variables" — this requirement is not currently met. Colors like #060b35 (nav links), #00acdc (accent/hover color), #34568b (title hover), and #616070 are hardcoded throughout styles.scss, and repeated sizes like 60px and 50px appear multiple times without variables. To fix this, add a variables section at the top of your SCSS file with declarations like: scss $color-primary: #060b35; $color-accent: #00acdc; $color-secondary: #34568b; $color-muted: #616070; $size-large: 60px; $size-medium: 50px; Then replace all hardcoded instances with these variables. This improves maintainability and ensures consistency across your stylesheet.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/styles/styles.scss Outdated
Comment on lines +1 to +8
* {
box-sizing: border-box;
}

body {
margin: 0;
font-family: Roboto, Arial, sans-serif;
color: #060b35;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist violation: Colors #060b35, #00acdc, #34568b, #616070, #f3f3f3, #e1e7ed are repeated throughout the file but NOT stored in SCSS variables. The task checklist requires: 'Repeated sizes and special colors are put to variables'.

Comment thread src/styles/styles.scss Outdated
Comment on lines +7 to +8
font-family: Roboto, Arial, sans-serif;
color: #060b35;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist violation: The color #060b35 is hardcoded (lines 7, 50, 109, 153, 169) instead of using a variable.

Comment thread src/styles/styles.scss Outdated
Comment on lines +56 to +72
color: #00acdc;
}
}
}

.is-active {
color: #00acdc;

&::after {
content: '';
position: absolute;
bottom: 0;
left: 0;
width: 100%;
height: 4px;
border-radius: 8px;
background-color: #00acdc;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist violation: The color #00acdc is hardcoded (lines 56, 61, 72, 176, 177, 178, 191, 192) instead of using a variable.

Comment thread src/styles/styles.scss Outdated
Comment on lines +121 to +122
&:hover .card__title {
color: #34568b;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist violation: The color #34568b is hardcoded (line 121) instead of using a variable.

Comment thread src/styles/styles.scss Outdated
Comment on lines +135 to +147
color: #616070;
font-size: 10px;
line-height: 14px;
}

&__price {
display: flex;
justify-content: space-between;
align-items: center;
margin-bottom: 16px;

&-label {
color: #616070;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist violation: The color #616070 is hardcoded (lines 135, 147) instead of using a variable.

Comment thread src/styles/styles.scss Outdated
Comment on lines +18 to +19
height: 60px;
padding: 0 50px;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist violation: Repeated sizes like 60px (lines 18, 46, 48) and 50px (line 19) are hardcoded instead of using SCSS variables for consistency.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets all task requirements. The SCSS variables for colors ($color-primary, $color-accent, $color-secondary, $color-muted) and sizes ($size-large, $size-medium) are properly declared and used throughout. BEM methodology is consistently applied across Header, Stars, and Card blocks. All required data-qa attributes are in place, responsive grid breakpoints work correctly (1/2/3/4 columns), and hover transitions are smooth at 300ms with proper scaling and z-index handling. The catalog styling with card dimensions, gaps, and padding all match specifications. Great work addressing the previous feedback and implementing a clean, standards-compliant solution.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, but the demo does not see stelys. to fix this, put the dot before the link (and the same with images)

Image

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEMO LINK still not fixed, check the suggested fix from @etojeDenys

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants