Skip to content

transitions was added#1383

Open
ihor-soloviov wants to merge 1 commit into
mate-academy:masterfrom
ihor-soloviov:develop
Open

transitions was added#1383
ihor-soloviov wants to merge 1 commit into
mate-academy:masterfrom
ihor-soloviov:develop

Conversation

@ihor-soloviov
Copy link
Copy Markdown

Comment thread src/styles/blocks/header.scss Outdated
color: #060b35;
list-style: none;
line-height: 60px;
transition: $transition-time;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to indicate which property you animated.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, add style into transition

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops

Comment thread src/styles/blocks/header.scss Outdated
color: #060b35;
list-style: none;
line-height: 60px;
transition: $transition-time;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, add style into transition

Copy link
Copy Markdown

@Anna-Tkachenko Anna-Tkachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants