Skip to content

add task solution#1999

Open
Albert-Kifiuk wants to merge 3 commits into
mate-academy:masterfrom
Albert-Kifiuk:develop
Open

add task solution#1999
Albert-Kifiuk wants to merge 3 commits into
mate-academy:masterfrom
Albert-Kifiuk:develop

Conversation

@Albert-Kifiuk
Copy link
Copy Markdown

Comment thread src/index.html
Comment thread src/styles/blocks/catalog.scss Outdated
@Albert-Kifiuk Albert-Kifiuk requested a review from OleziO June 9, 2023 10:22
Copy link
Copy Markdown

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍
I've added a few minor comments

Comment thread src/styles/blocks/catalog.scss Outdated
color: $text-secondary-color;
}

.code {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to create BEM mix here
it's just BEM element, so you can set margin in &__code

Comment thread src/styles/blocks/catalog.scss
Comment thread src/styles/blocks/catalog.scss Outdated
@@ -1,25 +1,149 @@
.catalog {
.card-conteiner {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.card-conteiner {
.card-container {

typo

@witflash witflash self-requested a review June 12, 2023 13:11
@Albert-Kifiuk Albert-Kifiuk reopened this Jun 12, 2023
Copy link
Copy Markdown

@witflash witflash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@witflash witflash self-requested a review June 12, 2023 13:39
Copy link
Copy Markdown

@witflash witflash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again

@ihor-jpeg ihor-jpeg self-requested a review June 13, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants