Develop#2002
Open
Patryk-Buczkowski wants to merge 3 commits into
Open
Conversation
Patryk-Buczkowski
commented
Jun 11, 2023
Patryk-Buczkowski
commented
- DEMO LINK
DorotaLeniecDev
approved these changes
Jun 12, 2023
DorotaLeniecDev
left a comment
DorotaLeniecDev
left a comment
There was a problem hiding this comment.
Good job, two sugestions from my side
| @@ -0,0 +1,3 @@ | |||
| $card-width: 200px; | |||
| $card-height: 300px; | |||
| $link-hover-color: #00acdc; | |||
There was a problem hiding this comment.
Good practice is to name colors like:
Suggested change
| $link-hover-color: #00acdc; | |
| $color-blue-accent: #00acdc; |
| text-transform: uppercase; | ||
| font-size: 12px; | ||
| font-weight: 500; | ||
| transition: all 300ms; |
There was a problem hiding this comment.
Specify the transition property for readability:
Suggested change
| transition: all 300ms; | |
| transition: color 300ms; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.