Skip to content

add task solution#2024

Open
MayerLansky wants to merge 2 commits into
mate-academy:masterfrom
MayerLansky:develop
Open

add task solution#2024
MayerLansky wants to merge 2 commits into
mate-academy:masterfrom
MayerLansky:develop

Conversation

@MayerLansky
Copy link
Copy Markdown

Copy link
Copy Markdown

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but you have mistakes in your transition property. Please fix it.

Comment thread src/styles/blocks/catalog.scss Outdated
justify-content: center;
align-items: center;
box-sizing: border-box;
transition: transform 300ms;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transition: transform 300ms;
transition: scale 300ms,
color 300ms;

Comment thread src/styles/blocks/header.scss Outdated
text-transform: uppercase;
font-size: 12px;
font-weight: 500;
transition: transform 300ms;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transition: transform 300ms;
transition: color 300ms;

@MayerLansky MayerLansky requested a review from vadiimvooo May 19, 2024 16:32
Copy link
Copy Markdown

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants