Skip to content

add task solution 1.0#752

Open
MBondhub wants to merge 5 commits into
mate-academy:masterfrom
MBondhub:develop
Open

add task solution 1.0#752
MBondhub wants to merge 5 commits into
mate-academy:masterfrom
MBondhub:develop

Conversation

@MBondhub
Copy link
Copy Markdown

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job
to improve:

  1. these should be tel links
Image
  1. prevent this text from wrapping
Image
  1. this text should be bigger
Image
  1. add some hover effects to the buttons and images
Image
  1. make sure the desktop version looks the same as the layout
Image
  1. disable page scrolling when the menu is open

  2. add smooth scroll behavior

@MBondhub MBondhub requested a review from etojeDenys April 12, 2026 17:29
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, let's make few changes:

  1. This button do nothing for now, let's initiate a call or refer to concatc us section:
Image
  1. Add scale effect to all pictures:
Image
  1. Add underline hover to this buttons:
Image
  1. Add hover effect to all links in this section:
Image
  1. This icons should lead to existing proper resourses:
Image

@MBondhub MBondhub requested a review from brespect April 13, 2026 19:02
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments from my previous review were not fixed.

@MBondhub MBondhub requested a review from brespect April 24, 2026 18:14
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. disable page scrolling when the menu is open
Image
  1. there is too much space on the desktop version
Image
  1. add a smooth scroll behaviour to the page

@MBondhub MBondhub requested a review from etojeDenys April 24, 2026 19:50
Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants