add task solution#762
Conversation
brespect
left a comment
There was a problem hiding this comment.
Good progress, but you need to add your DEMO LINK tot he PR description
|
Done, I’ve added the demo link to the PR description |
|
Thank you, I have a couple of questions regarding the review comments.
&:has(.page__menu:target) { If the comment refers to: .menu { I added it intentionally as a fallback in case the menu contains more items in the future and doesn't fit into the viewport. As far as I remember, we used the same approach in a previous project. Could you please clarify what should be changed here?
At the moment I left the second option. Which approach would you prefer for this project? |
|
Thank you for the clarification. Just to note, this solution was already implemented before the review comment was left: .page:has(.page__menu:target) { This code has been in the project from the beginning and page scrolling is already disabled when the menu is open. Could you please clarify if there is another issue with the menu that should be fixed? |



DEMO LINK:
https://iryna8989.github.io/layout_creativeBakery/