Skip to content

solution#2966

Open
Patryk-Buczkowski wants to merge 12 commits into
mate-academy:masterfrom
Patryk-Buczkowski:develop
Open

solution#2966
Patryk-Buczkowski wants to merge 12 commits into
mate-academy:masterfrom
Patryk-Buczkowski:develop

Conversation

@Patryk-Buczkowski
Copy link
Copy Markdown

@DorotaLeniecDev DorotaLeniecDev self-requested a review May 25, 2023 13:54
Copy link
Copy Markdown

@Radoslaw-Czerniawski Radoslaw-Czerniawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment on the code structure, will look into css after you deploy the demo.

Comment thread src/index.html
<link rel="stylesheet" href="./style.css">
</head>
<body>
<div class="container">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally you should have an empty line only between siblings of a parent not parent and child,

<div>
  <span>first child</span>

  <span>first child</span>
</div>

also like here when you have exact same elements next to each other then don't do any empty lines between them, like in this example:

<ul>
  <li>text</li>
  <li>text</li>
  <li>text</li>
  <li>text</li>
</ul>

Copy link
Copy Markdown

@Radoslaw-Czerniawski Radoslaw-Czerniawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, move the styling higher

Comment thread src/style.css
margin: 0;
}

.container {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally you are doing a mobile first approach here, where you first style for screen smaller than 600px, that's good however when doing so logically these style for screen smaller than 600px should be declared before @media (min-width:600px), move these lines beginning at line 53 after * { box-sizing: border-box; }

Copy link
Copy Markdown

@Radoslaw-Czerniawski Radoslaw-Czerniawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants