Skip to content

Solution#942

Open
TetianaSobolieva wants to merge 1 commit into
mate-academy:masterfrom
TetianaSobolieva:develop
Open

Solution#942
TetianaSobolieva wants to merge 1 commit into
mate-academy:masterfrom
TetianaSobolieva:develop

Conversation

@TetianaSobolieva
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets all core requirements. The Express server correctly provides both Users and Expenses collections with all 5 CRUD endpoints each, properly handles 400/404 error responses, uses in-memory storage as specified, and exports the app via createServer() without calling app.listen(). All 10 checklist items pass or partially pass.

A couple of minor improvements to be aware of (not blocking): the categories filter treats the parameter as a single value, so if the Swagger spec requires array support (e.g., ?categories=travel&categories=food), that logic would need updating. Additionally, PATCH on expenses doesn't currently validate that the associated user still exists, which is a optional hardening consideration.

Overall solid work—your solution is approved and ready for the next step.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants