c_1#1120
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is almost complete, but there is one critical issue that must be fixed. In src/createServer.js at line 44, the error response uses 'Errors' as the statusText instead of the required 'Bad request'. The task explicitly requires status 400 with Bad request statusText for error responses, and this is checklist item #17. Change res.writeHead(400, 'Errors', ...) to res.writeHead(400, 'Bad request', ...) to match the requirements. All other checklist items (URL parsing, validation logic, case conversion, response formatting) are correctly implemented, so only this single change is needed to pass all tests.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| }); | ||
| } | ||
|
|
||
| if (errors.length > 0) { |
There was a problem hiding this comment.
Status text should be 'Bad request' instead of 'Errors' to match the requirements in checklist item #17. The task explicitly states: status 400 with Bad request statusText.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is now complete and correct. The critical issue from the previous review has been fixed—res.writeHead(400, 'Bad request', ...) is now properly used instead of the incorrect 'Errors' statusText on line 44. All requirements are satisfied: URL parsing, validation logic for both text and toCase parameters, case conversion invocation, proper error/success responses with correct status codes and body formats, and appropriate Content-Type headers. All 15 checklist items pass. Great work on resolving the previous issue!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.