first touch#2254
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The request meets the required criteria for approval.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| def cache(func: Callable) -> Callable: | ||
| # Write your code here | ||
| pass | ||
| results = {} |
There was a problem hiding this comment.
Critical bug: results = {} is defined in the outer scope of the cache function, meaning ALL decorated functions share the same cache dictionary. This violates the requirement that the decorator 'should work correctly with few decorated functions simultaneously and correctly return for every function separately.' Move results = {} inside the wrapper function so each decorated function has its own isolated cache.
| pass | ||
| results = {} | ||
|
|
||
| @wraps |
There was a problem hiding this comment.
The @wraps decorator requires the func argument to properly preserve the original function's metadata. Change @wraps to @wraps(func).
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. The cache decorator implementation correctly handles all requirements: it stores function results in a dictionary keyed by arguments using *args, returns cached values when available, prints the appropriate messages ("Getting from cache" and "Calculating new result"), and properly isolates each decorated function's cache using closure. The implementation is clean, well-structured, and follows consistent code style throughout. Great work implementing this!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.