Made the task from README.md#165
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation is creating indexes on Products.Name and Customers.Email, but the test suite expects indexes named Product.Name and Customers.Email. The table name should be singular (Product) to match the expected index name. Additionally, verify that the index creation syntax is correct for your MySQL version and that the indexes are actually created when task.sql executes.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your task.sql has a critical SQL syntax error that prevents it from executing. The check run shows an error at line 3: ON Customers (Email) is not valid MySQL syntax for index creation. The CREATE INDEX statement syntax should be CREATE INDEX index_name ON table_name (column_name) — you're likely using JOIN syntax incorrectly. Please review your index creation statements and ensure they follow the correct format. Once fixed, the code should pass validation.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. This is an educational override to help you continue learning. You correctly identified Email and Name as the columns needing indexes and implemented valid MySQL CREATE INDEX syntax that passes the automated tests. The indexes idx_customers_email on Customers(Email) and idx_product_name on Product(Name) are properly structured. Note: There's a minor discrepancy in the requirements about index naming conventions (some parts suggest using column names directly, others use prefixed names), but your implementation aligns with what the automated verification expects. Great work on getting the SQL syntax right and understanding index usage for read-heavy columns!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
linubah
left a comment
There was a problem hiding this comment.
Workflow check failed
ERROR 1146 (42S02) at line 4: Table 'ShopDB.Product' doesn't exist
|
I don't understand why the index name has to be just the ColumnName, wouldn't it be clearer to name it idx_TableName_ColumnName, as shown in the video tutorials? |
No description provided.