Skip to content

solution by ten4i #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ten4i wants to merge 3 commits into
base: main
Choose a base branch
from
Open

solution by ten4i #172

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28de686
solution by ten4i
ten4i May 9, 2026
373544f
moved insert into transaction
ten4i May 9, 2026
e612de9
returned the insertion on an old place
ten4i May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions task.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
-- Use our database
USE ShopDB;

-- Some data should be created outside the transaction (here)
INSERT INTO Orders (CustomerID, DATE) VALUES (1, '2023-01-01');
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The INSERT INTO Orders statement must be moved inside the transaction block (after START TRANSACTION). Currently, if OrderItems insert or Products update fails, you'll be left with an orphaned empty order, violating atomicity requirements.


-- Start the transaction
START TRANSACTION;

-- And some data should be created inside the transaction

COMMIT;
INSERT INTO OrderItems (OrderID, ProductID, Count) VALUES (1, 1, 1);
UPDATE Products SET WarehouseAmount = WarehouseAmount - 1 WHERE ID = 1;
COMMIT;
Loading