Add transaction for creating order and updating stock#174
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution has a critical issue that needs to be fixed. The test is failing because the UPDATE statement for the Orders table is being executed inside the transaction block, which violates the task requirements. The task specifically requires that Orders updates happen outside the transaction.
To fix this, move your Orders UPDATE statement to execute before the START TRANSACTION command, then keep only the order item creation and warehouse amount updates within the transaction. This ensures proper atomicity where the Orders update is independent from the transactional operations. The current structure with Orders inside the transaction is causing the test to fail, even though other aspects of your implementation are correct.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation correctly separates the Orders table INSERT (outside transaction) from the OrderItems and Products updates (inside transaction), ensuring proper atomicity for warehouse operations. The transaction with START TRANSACTION and COMMIT is properly structured, the order is created for customer ID 1 on 2023-01-01, and LAST_INSERT_ID() correctly links the order to its items. All requirements from the task checklist have been satisfied.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.