Develop#4431
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation successfully meets all mandatory requirements. The App.js is properly split into Welcome, Header, and Article components, each with their own folder and CSS file, and all components use export default as required. Tests are passing without any functional issues. A couple of minor cleanup items worth noting: there are placeholder comment blocks remaining in Header.jsx and Article.css from the original template that should be removed for code cleanliness. Additionally, while the task description marks a Navigation component as optional, you may consider extracting the .navigation__link styles from Header.css into a separate Navigation component if you want to strictly follow the BEM block separation principle. Overall, your solution is approved and demonstrates proper component decomposition. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| /* Put header styles here */ | ||
| .header { | ||
| width: 100%; | ||
| padding: 1em; | ||
| font-size: 140%; |
There was a problem hiding this comment.
These are placeholder comments from the original template - they should be removed now that the component is implemented. Replace with meaningful documentation or remove entirely.
| } | ||
|
|
||
| .article__paragraph { | ||
| margin: 0; |
There was a problem hiding this comment.
The .navigation__link CSS class represents a separate BEM block from the header. According to the task requirement to 'Split the App.js into components based on CSS blocks', this should be extracted into a separate Navigation component with its own folder.
| </a> | ||
| <a className="navigation__link" href="#contact"> | ||
| Contact | ||
| </a> |
There was a problem hiding this comment.
The .navigation__link CSS class represents a separate BEM block from the header. According to the task requirement to 'Split the App.js into components based on CSS blocks', navigation styles should be extracted into a separate Navigation component with its own folder.
React Decompose
Split the
App.jsinto components based on CSS blocks. CSS code should be split too.Article,HeaderandWelcomefolders inside./src/components/with required files.Navigationcomponent and move navigation there.export defaultfor all the components.Instructions
npm testto ensure your solutions is correct<your_account>with your Github username in the DEMO LINK and add it to the PR description