Develop#3589
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Thank you for your work! Before this can be approved, please update the Sum component to check if both a and b props are numbers. If either is not a number, display an error message as required by the checklist. This validation is a core requirement for the task. Once you add this check, your solution will fully meet the requirements. Keep going, you're almost there! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} | ||
| </p> | ||
| ); |
There was a problem hiding this comment.
Issue: The component does not validate if 'a' and 'b' are numbers. According to the checklist, you must display an error message if either prop is not a number. Consider adding a check for the types of 'a' and 'b' and rendering an error message if they are not numbers.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your code fully meets all the task requirements and handles all edge cases as expected. The Sum component validates props correctly, displays the sum or an error message as needed, and your test cases in App.jsx are thorough. Keep up the excellent work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
https://zbvika.github.io/react_sum/