Skip to content

C#4244

Open
vaynexx wants to merge 2 commits into
mate-academy:masterfrom
vaynexx:master
Open

C#4244
vaynexx wants to merge 2 commits into
mate-academy:masterfrom
vaynexx:master

Conversation

@vaynexx
Copy link
Copy Markdown

@vaynexx vaynexx commented Apr 25, 2026

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Changes are needed because there are critical task requirement violations that prevent your submission from meeting the specifications.

Critical Issues:

  1. Missing separate Sum component file — The task requires creating Sum as a separate component (likely in src/components/Sum.jsx or similar), not defined inside App. You need to remove the local Sum definition from App.jsx and import it from its own file using a named export.

  2. No named export — The task explicitly requires a named export for the Sum component. Add export const Sum = ... in the component file.

  3. Template literal not used — Your implementation uses separate JSX expressions ({a} and {b}) instead of template literal interpolation. Per [CHECKLIST ITEM #2], change this to:

    {`Sum of ${a} and ${b} is ${a + b}`}
  4. Linter failure on react/no-unstable-nested-components — Defining Sum inside App's render function violates React's reconciliation rules. This is fixed by moving Sum to its own file.

Good news: Your e2e tests pass, and the logic for default values and the output format is correct. Once you extract Sum to its own file with a named export and fix the template literal, you'll be all set.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/App.jsx Outdated
Comment on lines +5 to +6
// Компонент Sum оголошуємо тут же
const Sum = ({ a = 0, b = 0 }) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component is defined inside App, but the task requires creating it as a separate component. Move Sum to its own file and use named export.

Comment thread src/App.jsx Outdated
Comment on lines +9 to +10
<p>
Sum of {a} and {b} is {result}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. Use template literals like {Sum of ${a} and ${b} is ${a + b}} instead of separate JSX expressions.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution fully meets all task requirements. The Sum component is properly extracted to its own file with a named export, uses template literal interpolation as specified, and correctly implements default values for both props. All five required Sum instances are rendered in App.jsx with the correct props and formatting. All previous review issues have been resolved, and there are no remaining critical blockers. Great work on completing this task!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants