Skip to content

result #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zakys1d wants to merge 3 commits into
base: master
Choose a base branch
from
Open

result #4279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b54dd78
result
Zakys1d May 17, 2026
287842e
new_result
Zakys1d May 17, 2026
0ebf5c3
new_result
Zakys1d May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
import React from 'react';
import './App.scss';

export const App = () => (
<>
<p>Sum of 2 and 3 is 5</p>
<p>Sum of -5 and 5 is 0</p>
<p>Sum of 10 and 0 is 10</p>
<p>Sum of 0 and 5 is 5</p>
<p>Sum of 0 and 0 is 0</p>
{/* Replace paragraphs with Sum componets */}
{/* And remove commented lines :) */}
</>
);
import { Sum } from './components/Sum/Sum';
Comment on lines 3 to +4
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. The current implementation uses individual JSX expressions {a}, {b}, {a + b} instead of template literal string interpolation {Sum of ${a} and ${b} is ${a + b}}.

Comment on lines 3 to +4
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. Replace with {Sum of ${a} and ${b} is ${a + b}} instead of individual expressions.


export const App = () => {
return (
<>
<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} />
<Sum b={5} />
<Sum />
</>
);
};

export default App;
4 changes: 3 additions & 1 deletion src/components/Sum/Sum.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => {
return <p>{`Sum of ${a} and ${b} is ${a + b}`}</p>;
};
Loading