Skip to content

add task solution#4287

Open
chlodav wants to merge 1 commit into
mate-academy:masterfrom
chlodav:develop
Open

add task solution#4287
chlodav wants to merge 1 commit into
mate-academy:masterfrom
chlodav:develop

Conversation

@chlodav
Copy link
Copy Markdown

@chlodav chlodav commented May 22, 2026

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is functionally correct and meets all core requirements. The Sum component properly accepts props with destructuring and default values, uses named exports, and all 5 required instances are present in App.jsx with correct default values. The feedback about template literals refers to checklist item #2, which is a code style preference. While the style guide recommends using template literals like `Sum of ${a} and ${b} is ${a + b}` instead of separate JSX expressions, this is a formatting/style issue rather than a functional problem. The linting checklist also classifies such style violations as non-blocking. Your code works correctly, and that's what matters most. Keep up the good work on the implementation!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/App.jsx
Comment on lines +2 to 3
import { Sum } from './components/Sum/Sum';
import './App.scss';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: use template literals inside tag content instead of separate JSX expressions. Change to {Sum of ${a} and ${b} is ${a + b}}

Comment on lines +1 to +3
export const Sum = ({ a = 0, b = 0 }) => (
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. The content should use template literals: {Sum of ${a} and ${b} is ${a + b}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants