Skip to content

add task solution #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OksanaSht wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #4292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
834f627
add task solution
OksanaSht May 28, 2026
7efd8ba
add task solution2
OksanaSht May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import React from 'react';
import './App.scss';
import { Sum } from './components/Sum/Sum';
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Use string interpolation inside tag content'. The backticks here are literal text, not template literal interpolation. The JSX needs curly braces around the template literal to evaluate ${a}, ${b}, and ${a + b}. Change to: {Sum of ${a} and ${b} is ${a + b}}

Comment on lines 2 to +3
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Violates checklist item #2: Use template literal string interpolation instead of multiple JSX expressions. Replace Sum of {a} and {b} is {a + b} with {Sum of ${a} and ${b} is ${a + b}}


export const App = () => (
<>
<p>Sum of 2 and 3 is 5</p>
<p>Sum of -5 and 5 is 0</p>
<p>Sum of 10 and 0 is 10</p>
<p>Sum of 0 and 5 is 5</p>
<p>Sum of 0 and 0 is 0</p>
{/* Replace paragraphs with Sum componets */}
{/* And remove commented lines :) */}
<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} />
<Sum b={5} />
<Sum />
</>
);
6 changes: 5 additions & 1 deletion src/components/Sum/Sum.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => (
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: use string interpolation inside tag content. Replace with template literal: {Sum of ${a} and ${b} is ${a + b}}

</p>
);
Loading