Skip to content

solution#4293

Open
GeorgeVeshchev wants to merge 1 commit into
mate-academy:masterfrom
GeorgeVeshchev:develop
Open

solution#4293
GeorgeVeshchev wants to merge 1 commit into
mate-academy:masterfrom
GeorgeVeshchev:develop

Conversation

@GeorgeVeshchev
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is approved. All functional requirements are met: the Sum component correctly accepts a and b props with defaults of 0, renders the proper paragraph format, uses named export, and all five required instances are present in App.jsx. While the code does not use template literal interpolation for the paragraph content (violating checklist item #2), this is a code style preference rather than a functional issue. Your implementation will work correctly with the test suite. Keep up the good work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines +5 to +6
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. Replace with template literal: {Sum of ${a} and ${b} is ${a + b}}

Comment thread src/App.jsx
import { Sum } from './components/Sum/Sum';

export const App = () => (
<>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. According to the requirements, template literals should be used instead of separate JSX expressions for better readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants