Skip to content

add task solution#4301

Open
vitamartsekhovska wants to merge 2 commits into
mate-academy:masterfrom
vitamartsekhovska:develop
Open

add task solution#4301
vitamartsekhovska wants to merge 2 commits into
mate-academy:masterfrom
vitamartsekhovska:develop

Conversation

@vitamartsekhovska
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is functionally correct and meets all core requirements—the Sum component properly accepts props with defaults, uses named export, and App includes all 5 required instances. However, there's a checklist violation that needs to be addressed.

Required fix: In src/components/Sum/Sum.jsx, the paragraph currently uses individual JSX expressions like {a}, {b}, {a + b}. Per [CHECKLIST ITEM #2], you need to use string interpolation with a template literal instead. Change:

<p>Sum of {a} and {b} is {a + b}</p>

to:

<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>

This is a straightforward fix—functionality remains unchanged, just the string formatting approach needs adjustment to match the checklist requirement.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/App.jsx
Comment on lines 1 to +3
import React from 'react';
import './App.scss';
import { Sum } from './components/Sum/Sum';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Use string interpolation inside tag content'. The paragraph should use template literals instead of separate JSX expressions. Replace Sum of {a} and {b} is {a + b} with {Sum of ${a} and ${b} is ${a + b}}

Comment thread src/components/Sum/Sum.jsx Outdated
// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => (
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. Replace with {Sum of ${a} and ${b} is ${a + b}}

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution fully meets all task requirements. The Sum component correctly uses named export, accepts a and b props with default values of 0, and renders the sum text using template literal interpolation (Sum of ${a} and ${b} is ${a + b}). The App component properly includes all 5 required Sum instances with the correct props. All checklist items are satisfied, and no test failures or build errors were reported. Great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants