-
Notifications
You must be signed in to change notification settings - Fork 1.5k
solution #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danf4691
wants to merge
11
commits into
mate-academy:master
Choose a base branch
from
danf4691:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
solution #1295
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
19a0e1e
solution
danf4691 d11d733
solution2
danf4691 f7c074c
solution
danf4691 88d9e5a
extention fix
danf4691 4cf8a81
test fix1
danf4691 c78065b
test fix2
danf4691 31fcbf9
test fix3
danf4691 7931c96
test fix4
danf4691 84d860b
test fix5
danf4691 7dd8009
test fix6
danf4691 684d363
Rename todoContext.tsx to TodoContext.tsx
danf4691 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous review recommended adding file extensions to local imports to resolve a build issue. Disabling this rule prevents ESLint from enforcing this practice, which can hide potential module resolution problems. Please consider configuring this rule to require extensions for
.tsand.tsxfiles to improve clarity and avoid future issues.