Skip to content

Implement ToDo App#1301

Open
Dianaeva wants to merge 1 commit into
mate-academy:masterfrom
Dianaeva:develop
Open

Implement ToDo App#1301
Dianaeva wants to merge 1 commit into
mate-academy:masterfrom
Dianaeva:develop

Conversation

@Dianaeva
Copy link
Copy Markdown

Copy link
Copy Markdown

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving it, but please pay attention to the comments from previous tasks

Comment on lines +20 to +23
//
// {/* This is a completed todo */}
// <div data-cy="Todo" className="todo completed">
// <label className="todo__status-label">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove the comments

| { type: 'UPDATE_TODO_TITLE'; payload: { id: Todo['id']; title: string } };

const reducer = (state: Todo[], action: Action) => {
if (action.type === 'ADD_TODO') {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use switch..case instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants