Skip to content

add solution#1303

Open
Yevhen-Srdk wants to merge 1 commit into
mate-academy:masterfrom
Yevhen-Srdk:develop
Open

add solution#1303
Yevhen-Srdk wants to merge 1 commit into
mate-academy:masterfrom
Yevhen-Srdk:develop

Conversation

@Yevhen-Srdk
Copy link
Copy Markdown

Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

One tiny thing to improve:

  1. Clear completed should be disabled or hidden when there aren't any completed todos
Image

@Yevhen-Srdk
Copy link
Copy Markdown
Author

Good job!

One tiny thing to improve:

1. `Clear completed` should be disabled or hidden when there aren't any completed todos
Image

Hello! The button has a disabled logic:

<button
        type="button"
        className="todoapp__clear-completed"
        data-cy=“ClearCompletedButton”
        onClick={clearCompletedTodos}
        disabled={todos.every(todo => !todo.completed)}
      >
        Clear Completed
</button>

The issue might be with the CSS styles, so when you hover over the button, it gets underlined and looks like it’s active, but it isn’t. By the way, it’s the same in the working example.

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants