implement solution#1310
Open
whomngmnt wants to merge 1 commit into
Open
Conversation
DanilWeda
approved these changes
May 25, 2026
DanilWeda
left a comment
DanilWeda
left a comment
There was a problem hiding this comment.
Great!
Approved with minor comments.
Many thanks!
|
|
||
| const { todos, filter } = context.state; | ||
| const visibleTodos = todos.filter(todo => { | ||
| if (filter === 'active') { |
There was a problem hiding this comment.
Better option create Enum for filter status and use it in all place (one source of truth, easy changes in future )
| import { useContext } from 'react'; | ||
| import { FilterStatus, TodoContext } from '../Context/TodoContext'; | ||
|
|
||
| const filters: { label: string; value: FilterStatus; dataCy: string }[] = [ |
There was a problem hiding this comment.
Also you can use Enum for value in this case.
| completed?: boolean; | ||
| }; | ||
|
|
||
| export type Action = |
There was a problem hiding this comment.
You also can describe Actions as Enum (not critical)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DEMO LINK] https://whomngmnt.github.io/react_todo-app/