solution#1315
Open
shtoikoihor wants to merge 3 commits into
Open
Conversation
brespect
suggested changes
Jun 1, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, but you need to add the DEMO LINK to PR description
Anton-Kuchmasov
suggested changes
Jun 1, 2026
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Great job you did!
Would you mind to fix this UI bug?
Also check out comments below - they might be helpful
|
|
||
| <div className="todoapp__content"> | ||
| <header className="todoapp__header"> | ||
| {/* this button should have `active` class only if all todos are completed */} |
| <header className="todoapp__header"> | ||
| {/* this button should have `active` class only if all todos are completed */} | ||
|
|
||
| {todos.length > 0 && ( |
There was a problem hiding this comment.
Suggested change
| {todos.length > 0 && ( | |
| {!!todos.length && ( |
| <TodoForm /> | ||
| </header> | ||
|
|
||
| {todos.length > 0 && <TodoList />} |
| export function useTodos() { | ||
| const context = useContext(TodoContext); | ||
|
|
||
| if (context === null) { |
There was a problem hiding this comment.
Suggested change
| if (context === null) { | |
| if (!context) { |
Anton-Kuchmasov
approved these changes
Jun 1, 2026
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Good job, but don't forget to re-deploy your solution before requesting a next review
also, it can be fixed just by only adding box-sizing: border-box
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://shtoikoihor.github.io/react_todo-app/