Repository navigation
fix(EN10168 v0.5.0): render url / qr-code / image supplementary values in the product description - #333
Merged
Conversation
…s in the product description ProductDescription.SupplementaryInformation never passed a value's Type to the KeyValue template, so a B-field with Type "url" printed as plain text and one with Type "qr-code" or "image" printed its data URI as text. Seen on the Steel Mill SE demo certificate, where B20 carries the passport URL and B21 the passport QR code. For Type url, email, phone, qr-code and image, the bare Value and the Type are now passed, so the template renders a link or a graphic. Every other type keeps the "Value Unit" text it always rendered. Mirror of material-identity/schema legacy/schemas/EN10168/v0.5.0/stylesheet.xsl (schema PR #405); the two files are byte-identical again. Checked by rendering all 12 test/fixtures/EN10168/v0.5.0 certificates with the old and the new stylesheet: text output identical. npx jest: 272 passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
asamark
approved these changes
Oct 5, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`ProductDescription.SupplementaryInformation` never passed a value's `Type` to the `KeyValue` template:
It surfaced on the Steel Mill SE demo certificate: B20 holds the passport URL and B21 the passport QR code. With the old stylesheet B21 renders as `data:image/…`.
Fix
For `url`, `email`, `phone`, `qr-code` and `image`, the bare `Value` and the `Type` are passed, so the template renders a link or a graphic. Every other type keeps its "Value Unit" text.
This mirrors material-identity/schema `legacy/schemas/EN10168/v0.5.0/stylesheet.xsl` (schema PR #405); the two files are byte-identical again.
Verification
🤖 Generated with Claude Code