Repository navigation
feat(metals): render Order.CustomerProductName and Delivery.InternalOrderId (schema#426) - #343
Merged
stiebitzhofer merged 3 commits intoOct 5, 2026
Conversation
…rderId (material-identity/schema#426) The Metals v0.1.1 certificate dropped both fields silently. They now print on the grey detail line under the Order and Delivery rows, labelled through mi:label (EN "Customer Product Name" / "Internal Order ID", DE from translation.json), and only when present: a certificate without them renders exactly as before (Interfer 30/30 and Everest 37/37 unchanged). Re-baselines the 19 Metals v0.1.1 fixtures that carry InternalOrderId (text diff is additions only, plus one note moving across a page break in product_shapes and word_wrap_breaks). valid_extruded_aluminium_profile gains a CustomerProductName so both fields are covered. Builds on the #331 translated-labels branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s-order-fields-426
…non-empty (material-identity/schema#426) The guards tested for the element only, so "InternalOrderId": "" printed "Internal Order ID: " with nothing after it. normalize-space() also skips whitespace-only values. No fixture changes: every committed fixture carries non-empty values (review finding on #343). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
asamark
approved these changes
Oct 5, 2026
stiebitzhofer
merged commit Oct 5, 2026
b5a0d23
into
feat/metals-v011-translated-labels-331
2 checks passed
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of material-identity/schema#426. Stacked on #342 (issue #331) — review and merge #342 first; this diff shows only the #426 change.
What
The Metals v0.1.1 certificate silently dropped
Order.CustomerProductNameandDelivery.InternalOrderId. They now print on the grey detail line under the Order and Delivery rows ("Customer Product Name: …", "Internal Order ID: …"), labelled throughmi:label(bilingual when the certificate lists DE), and only when present.Everest needs both: its certificates carry the customer's own product reference and Everest's internal order number (
EAO…).Fixtures
InternalOrderIdand are re-baselined. A word diff shows additions only; inproduct_shapesandword_wrap_breaksone note ("1 3 specimens tested") moves across a page break, nothing lost.valid_extruded_aluminium_profilegains aCustomerProductNameso both fields are covered. Checked visually: long values wrap within the column, no overlap.Gates
jest test/metals-labels.spec.jsnpx jestmvn test -Dtest=RenderTest,TranslationLoaderTestcompareCustomerInterfer / EverestMirror PR in material-identity/schema follows.
🤖 Generated with Claude Code