Skip to content

feat(metals): render Order.CustomerProductName and Delivery.InternalOrderId (schema#426) - #343

Merged
stiebitzhofer merged 3 commits into
feat/metals-v011-translated-labels-331from
feat/metals-order-fields-426
Oct 5, 2026
Merged

stiebitzhofer merged 3 commits into
feat/metals-v011-translated-labels-331from
feat/metals-order-fields-426

Conversation

@stiebitzhofer

@stiebitzhofer stiebitzhofer commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Part of material-identity/schema#426. Stacked on #342 (issue #331) — review and merge #342 first; this diff shows only the #426 change.

What

The Metals v0.1.1 certificate silently dropped Order.CustomerProductName and Delivery.InternalOrderId. They now print on the grey detail line under the Order and Delivery rows ("Customer Product Name: …", "Internal Order ID: …"), labelled through mi:label (bilingual when the certificate lists DE), and only when present.

Everest needs both: its certificates carry the customer's own product reference and Everest's internal order number (EAO…).

Fixtures

  • 19 existing fixtures already carried InternalOrderId and are re-baselined. A word diff shows additions only; in product_shapes and word_wrap_breaks one note ("1 3 specimens tested") moves across a page break, nothing lost.
  • valid_extruded_aluminium_profile gains a CustomerProductName so both fields are covered. Checked visually: long values wrap within the column, no overlap.
  • The 11 fixtures without the fields render identically.

Gates

Gate Result
jest test/metals-labels.spec.js 332 passed
npx jest 605 passed, 3 skipped
mvn test -Dtest=RenderTest,TranslationLoaderTest 141/142; Bluemint fixture missing from fresh worktree, unrelated
material-identity/schema compareCustomer Interfer / Everest 30/0 and 37/0

Mirror PR in material-identity/schema follows.

🤖 Generated with Claude Code

…rderId (material-identity/schema#426)

The Metals v0.1.1 certificate dropped both fields silently. They now print on
the grey detail line under the Order and Delivery rows, labelled through
mi:label (EN "Customer Product Name" / "Internal Order ID", DE from
translation.json), and only when present: a certificate without them renders
exactly as before (Interfer 30/30 and Everest 37/37 unchanged).

Re-baselines the 19 Metals v0.1.1 fixtures that carry InternalOrderId (text
diff is additions only, plus one note moving across a page break in
product_shapes and word_wrap_breaks). valid_extruded_aluminium_profile gains
a CustomerProductName so both fields are covered.

Builds on the #331 translated-labels branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@eamon0989
eamon0989 temporarily deployed to s1-schemas-pr-343 October 4, 2026 07:54 Inactive
stiebitzhofer and others added 2 commits October 4, 2026 10:20
…non-empty (material-identity/schema#426)

The guards tested for the element only, so "InternalOrderId": "" printed
"Internal Order ID: " with nothing after it. normalize-space() also skips
whitespace-only values. No fixture changes: every committed fixture carries
non-empty values (review finding on #343).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stiebitzhofer
stiebitzhofer temporarily deployed to s1-schemas-pr-343 October 4, 2026 08:26 Inactive
@asamark
asamark requested review from asamark and removed request for asamark October 5, 2026 07:06
@stiebitzhofer
stiebitzhofer merged commit b5a0d23 into feat/metals-v011-translated-labels-331 Oct 5, 2026
2 checks passed
@stiebitzhofer
stiebitzhofer deleted the feat/metals-order-fields-426 branch October 5, 2026 08:41

This branch was previously deployed

1 inactive deployment
s1-schemas-pr-343 — 3ac6e7bc Deployed Oct 4, 2026 by stiebitzhofer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants