Skip to content

fix: make final4 pick counting tolerant to id drift #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateu merged 1 commit into from
Apr 5, 2026
Merged

fix: make final4 pick counting tolerant to id drift #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions lib/Bracket/Model/DBIC.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,21 +581,26 @@ sub count_final4_picks {
my ($self, $player_id) = @_;
return 0 if !defined $player_id;
my $final4_game_ids = Bracket::Service::BracketStructure->final4_game_ids($self->schema) || [];
my $where = {
'me.player' => $player_id,
'game.round' => { '>=' => 5 },
};

if (@{$final4_game_ids}) {
return $self->schema->resultset('Pick')->search({
player => $player_id,
game => { -in => $final4_game_ids },
})->count;
# Keep structure-derived IDs, but also allow round-derived final4 games
# so this count remains correct when game IDs/topology drift.
$where = {
'me.player' => $player_id,
-or => [
'me.game' => { -in => $final4_game_ids },
'game.round' => { '>=' => 5 },
],
};
}

return $self->schema->resultset('Pick')->search(
{
'me.player' => $player_id,
'game.round' => { '>=' => 5 },
},
{
join => 'game',
}
$where,
{ join => 'game' }
)->count;
}

Expand Down
Loading