Skip to content

feat: zoom, sidebar, Ctrl+P, drag crash#30

Merged
jrandolf merged 1 commit into
mainfrom
feat/fix-issues
Mar 11, 2026
Merged

feat: zoom, sidebar, Ctrl+P, drag crash#30
jrandolf merged 1 commit into
mainfrom
feat/fix-issues

Conversation

@jrandolf

@jrandolf jrandolf commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Set pdf.defaultZoomValue to page-width and open a PDF — verify it opens at that zoom
  • Set pdf.sidebarViewOnLoad to 2 and open a PDF — verify the outline panel opens
  • Press Ctrl+P / Cmd+P with a PDF open — verify no print dialog appears
  • Select text in a PDF and drag it — verify the viewer stays intact

🤖 Generated with Claude Code

@jrandolf jrandolf changed the title Fix five open issues: zoom, sidebar, dark mode, Ctrl+P, drag crash Fix four open issues: zoom, sidebar, Ctrl+P, drag crash Mar 11, 2026
@jrandolf jrandolf changed the title Fix four open issues: zoom, sidebar, Ctrl+P, drag crash feat: zoom, sidebar, Ctrl+P, drag crash Mar 11, 2026
- Add `pdf.defaultZoomValue` and `pdf.sidebarViewOnLoad` VS Code settings
  (closes #11, #22)
- Prevent pdf.js from intercepting Ctrl+P / Cmd+P to trigger the print
  dialog (closes #13)
- Fix crash handler: only show error screen during load, not for post-load
  runtime errors like those triggered by dragging text (closes #21)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jrandolf jrandolf merged commit 50a181b into main Mar 11, 2026
1 check passed
@jrandolf jrandolf deleted the feat/fix-issues branch March 11, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant