You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This Pull Request fixes an issue where pending edits or changes submitted by users were not being sorted or displayed in the correct chronological or prioritized order.
Changes Introduced
Sorting Logic Fix: Corrected the underlying sorting algorithm/comparator applied to the pending changes list before it gets rendered or processed.
UI Consistency: Ensures that the most relevant or recent edits appear in the expected sequence inside the moderation/queue view, preventing layout confusion or outdated entries from overlapping.
Data Integrity: Cleaned up the data pipeline to handle null or missing timestamp values safely during the sorting process without crashing the collection view.
But old solution for sorting kept changed AEDs in the map visible.
I travel a lot between Kraków and Rzeszów and I think, user should be able to see edited AEDs in Kraków, while he moved to Rzeszów for a while.
What do you think?
This PR talks about chronological order, but clearly introduces distance-based sorting.
But old solution for sorting kept changed AEDs in the map visible. I travel a lot between Kraków and Rzeszów and I think, user should be able to see edited AEDs in Kraków, while he moved to Rzeszów for a while.
What do you think?
This PR talks about chronological order, but clearly introduces distance-based sorting.
I will think about it again.
I thought this as elegant solution as main problem to fix is the fact that when I edited AED it taken place as my nearest one, effectively killing main purpose of the map that is helping in emergency situations.
@Amadeusz-P Oh, really we have this bug? Considering scenario:
I edit some AED that is far away from me
I navigate to nearest AED
Shown AED is not really my nearest AED?
In such case following PR is crucial to fix the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes an issue where pending edits or changes submitted by users were not being sorted or displayed in the correct chronological or prioritized order.
Changes Introduced