feat: add screen reader semantics to map controls#51
Merged
Conversation
✅ Deploy Preview for aedmap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
chrisdebian
approved these changes
Jun 10, 2026
chrisdebian
left a comment
chrisdebian
left a comment
Contributor
There was a problem hiding this comment.
All seven tap targets from issue #41 are covered, labels are localised across all six languages, and the approach (wrapping in Semantics(button: true, label: ...)) is correct Flutter accessibility practice.
One optional follow-up: the navigate button could benefit from enabled: networkState.connected on its Semantics wrapper so screen reader users hear that it's inactive when offline. Not a blocker.
Great work — this is a meaningful safety improvement for an emergency-use app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.