Repository navigation
Conversation
…ves plugins Omarchy 4.0.3 sandboxes what third-party plugin code can see from the host shell: manifest.__sourceDir is stripped before a manifest reaches a plugin's service or bar widget, and `shell` is now a capability-scoped proxy exposing only `barConfig` rather than the full `shellConfig`. Both silently broke the MPD connection -- the bridge process was never spawned (empty sourceDir), and even when it was, the saved host/port never reached it (empty settings) -- so the widget hung on "Connecting to MPD..." forever with nothing logged. Derive sourceDir from where Service.qml was itself loaded from instead of the manifest, and read settings out of the scoped shell's barConfig, wrapped back into the shape lookupSettings expects. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Read saved settings through a watched adapter, resolve the bundled bridge locally, and read the public service version. Adapt the compatibility components and fixture from omawall PR #5. Co-authored-by: Richard Noh <richard.jun.noh@gmail.com>
|
Thanks for investigating this and submitting the fix. This addresses the same two causes we encountered: Omarchy no longer exposes I've already pushed 92248d4 to I verified the fix locally after restarting the shell: the MPD bridge starts, connects successfully, and loads the existing queue. All nine regression tests, the headless Quickshell compatibility fixture, plugin validation, and GitHub CI pass. I'm closing this PR as superseded by that commit. Thank you for the contribution and the clear diagnosis. |
Omarchy 4.0.3 sandboxes what third-party plugin code can see from the host shell:
manifest.__sourceDiris stripped before a manifest reaches a plugin's service or bar widget (omacom/omarchy#10863), andshellis now a capability-scoped proxy exposing onlybarConfigrather than the fullshellConfig. Both silently broke the MPD connection — the bridge process was never spawned, and even when it was, the saved host/port never reached it — so the widget hung on "Connecting to MPD..." forever with nothing logged.Derive
sourceDirfrom where Service.qml was itself loaded from instead of the manifest, and read settings out of the scoped shell'sbarConfig, wrapped back into the shapelookupSettingsexpects.