Skip to content

fix: stop relying on manifest/shell fields Omarchy 4.0.3 no longer gives plugins - #5

Closed
jabular wants to merge 1 commit into
matjam:mainfrom
jabular:fix/omarchy-4.0.3-plugin-sandboxing
Closed

jabular wants to merge 1 commit into
matjam:mainfrom
jabular:fix/omarchy-4.0.3-plugin-sandboxing

Conversation

@jabular

@jabular jabular commented Sep 12, 2026

Copy link
Copy Markdown

Omarchy 4.0.3 sandboxes what third-party plugin code can see from the host shell: manifest.__sourceDir is stripped before a manifest reaches a plugin's service or bar widget (omacom/omarchy#10863), and shell is now a capability-scoped proxy exposing only barConfig rather than the full shellConfig. Both silently broke the MPD connection — the bridge process was never spawned, and even when it was, the saved host/port never reached it — so the widget hung on "Connecting to MPD..." forever with nothing logged.

Derive sourceDir from where Service.qml was itself loaded from instead of the manifest, and read settings out of the scoped shell's barConfig, wrapped back into the shape lookupSettings expects.

…ves plugins

Omarchy 4.0.3 sandboxes what third-party plugin code can see from the host
shell: manifest.__sourceDir is stripped before a manifest reaches a plugin's
service or bar widget, and `shell` is now a capability-scoped proxy exposing
only `barConfig` rather than the full `shellConfig`. Both silently broke the
MPD connection -- the bridge process was never spawned (empty sourceDir), and
even when it was, the saved host/port never reached it (empty settings) -- so
the widget hung on "Connecting to MPD..." forever with nothing logged.

Derive sourceDir from where Service.qml was itself loaded from instead of the
manifest, and read settings out of the scoped shell's barConfig, wrapped back
into the shape lookupSettings expects.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
matjam added a commit that referenced this pull request Sep 15, 2026
Read saved settings through a watched adapter, resolve the bundled bridge locally, and read the public service version. Adapt the compatibility components and fixture from omawall PR #5.

Co-authored-by: Richard Noh <richard.jun.noh@gmail.com>
@matjam

matjam commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Thanks for investigating this and submitting the fix. This addresses the same two causes we encountered: Omarchy no longer exposes manifest.__sourceDir or shell.shellConfig to third-party plugins.

I've already pushed 92248d4 to main, which resolves both using the compatibility components tested in omawall. It also supports service-only settings entries, decodes URL-escaped helper paths, and restores the displayed version through the public service manifest.

I verified the fix locally after restarting the shell: the MPD bridge starts, connects successfully, and loads the existing queue. All nine regression tests, the headless Quickshell compatibility fixture, plugin validation, and GitHub CI pass.

I'm closing this PR as superseded by that commit. Thank you for the contribution and the clear diagnosis.

@matjam matjam closed this Sep 15, 2026
@jabular
jabular deleted the fix/omarchy-4.0.3-plugin-sandboxing branch September 29, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants