Mark initialization of OnceRef::get_or_try_init cold.#285
Merged
matklad merged 1 commit intomatklad:masterfrom Mar 28, 2025
Merged
Mark initialization of OnceRef::get_or_try_init cold.#285matklad merged 1 commit intomatklad:masterfrom
OnceRef::get_or_try_init cold.#285matklad merged 1 commit intomatklad:masterfrom
Conversation
Use `Self::get()` instead of directly loading the value, which is a DRY improvement in its own right. Then it is trivial to split out the initialization into a `#[cold]` function, matching the other implementations in the module. This is the `OnceRef` analog of commit 90da60b.
briansmith
force-pushed
the
b/once-ref-cold
branch
from
618ba37 to
a851cc4
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Self::get()instead of directly loading the value, which is a DRY improvement in its own right.Then it is trivial to split out the initialization into a
#[cold]function, matching the other implementations in the module.This is the
OnceRefanalog of commit 90da60b.