Remove is_blocked field from ComputedTask

[matta]

Removed is_blocked field from ComputedTask struct and related assignment in priority.rs, as well as updated tests and documentation.

---

PR created automatically by Jules for task 11144978107209981231 started by @matta

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[trunk-io]

Merging to main in this repository is managed by Trunk.

• To merge this pull request, check the box to the left or comment /trunk merge below.

[gemini-code-assist]

Summary of Changes

Hello @matta, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the core ComputedTask data structure by eliminating the is_blocked field. This change simplifies the internal representation, aligns the backend logic more closely with the frontend's needs, and reduces unnecessary complexity in priority calculation and testing by removing a field that was marked for removal.

Highlights

• ComputedTask struct: The is_blocked field has been removed from the ComputedTask struct definition in crates/tasklens-core/src/types/transient.rs.
• Priority calculation logic: The assignment of the is_blocked field has been removed from the get_prioritized_tasks function in crates/tasklens-core/src/domain/priority.rs.
• Test suite updates: The compliance.rs test file has been updated to remove references and assertion logic related to the is_blocked field.
• Documentation: The docs/design/test-suite.md documentation has been updated to reflect the removal of is_blocked from boolean exactness checks.

Changelog

• crates/tasklens-core/src/domain/priority.rs
  • Removed the assignment of the is_blocked field within the get_prioritized_tasks function, as the field is no longer part of ComputedTask.
• crates/tasklens-core/src/types/transient.rs
  • Removed the is_blocked field from the ComputedTask struct definition.
• crates/tasklens-core/tests/compliance.rs
  • Removed the is_blocked field from the ExpectedTaskProps struct and deleted the corresponding assertion logic in assert_state_props.
• docs/design/test-suite.md
  • Updated the documentation to remove is_blocked from the list of boolean checks requiring exactness.

Activity

• PR created automatically by Jules for task 11144978107209981231, initiated by @matta.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the is_blocked field from the ComputedTask struct, which is no longer needed. The change is consistently applied across the domain logic, tests, and documentation, simplifying the data model and aligning it with the TypeScript implementation. I've found one minor issue regarding a leftover comment that should be addressed to maintain code clarity.

I am having trouble creating individual review comments. Click here to see my feedback.

crates/tasklens-core/src/types/transient.rs (122-123)

There appears to be an off-by-one error in the lines removed. You've removed is_blocked (line 122) and the TODO comment for is_visible (line 123). This leaves the TODO comment from is_blocked (line 121) incorrectly pointing to is_visible.

The correct change would be to remove is_blocked and its own TODO comment, which are on lines 121 and 122.

[matta]

Waiting on the result of #480

[google-labs-jules]

Waiting on the result of #480

Understood. I will wait for the result of that PR.