Bugfix: Define optional 'properties' property if not present#6
Open
eastbayjake wants to merge 1 commit intomattcooper:masterfrom
Open
Bugfix: Define optional 'properties' property if not present#6eastbayjake wants to merge 1 commit intomattcooper:masterfrom
eastbayjake wants to merge 1 commit intomattcooper:masterfrom
Conversation
GeoJSON Point features require and properties, but is optional. The current method assumes that will exist and errors on the assignment if is not present. This fix initializes as an empty object if not present so the assignment on the next line should always work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeoJSON Point features require
typeandcoordinatesproperties, butpropertiesis optional. The currentloadPointDatamethod assumes thatfeatures.propertieswill exist and errors on thefeatures.properties.indexassignment iffeatures.propertiesis not present. This fix initializesfeatures.propertiesas an empty object if not present so the assignment on the next line should always work.