Fix crash with bad monitor id; add method to get full Oculus pose#7
Open
totalgee wants to merge 1 commit into
Open
Fix crash with bad monitor id; add method to get full Oculus pose#7totalgee wants to merge 1 commit into
totalgee wants to merge 1 commit into
Conversation
- also get Oculus monitor id in a more reliable way.
Author
|
Here are my comments from the other PR, which I retracted (this PR fixes the same problem, but in a more general way):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now figure out the Oculus monitor id in a more reliable way. Previously, it was sometimes crashing in
fullscreenOnRift()becausehmd->DisplayIdwas uninitialized.I also implemented the missing
getTranslation()method (was declared in the header but not implemented), and added a newgetFullHeadPose()method, that returns the full pose of the Oculus camera (including its parent ofCamera).This is a better fix than my earlier pull request, which I will retract.