Add Cursor Cloud specific instructions to AGENTS.md#3808
Closed
yasserfaraazkhan wants to merge 4 commits into
Closed
Add Cursor Cloud specific instructions to AGENTS.md#3808yasserfaraazkhan wants to merge 4 commits into
yasserfaraazkhan wants to merge 4 commits into
Conversation
Document how to run the Electron app in the Cloud Agent VM environment, including the required flags to work around network service subprocess crashes in containerized environments. Add quick reference for key development commands and gotchas. Co-authored-by: yasser khan <attitude3cena.yf@gmail.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Document setup steps, running commands, environment variables, and known container-environment limitations for the Playwright E2E test suite in Cloud Agent VMs. Co-authored-by: yasser khan <attitude3cena.yf@gmail.com>
- Remove --no-zygote flag: was preventing renderer child processes from spawning, causing all window URLs to be empty. The zygote process is essential for Chromium's process model. - Add --in-process-gpu and --enable-features=NetworkServiceInProcess2: prevents network service subprocess crashes in Firecracker/Docker. - Fix waitForAppReady to force-show the main window in headless/VNC environments where BrowserWindow.show() doesn't fire automatically. Before: only tests using emptyConfig (welcome screen) passed. After: 28+ tests pass including config, settings, menu bar, downloads. Co-authored-by: yasser khan <attitude3cena.yf@gmail.com>
Co-authored-by: yasser khan <attitude3cena.yf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-zygoteflag that prevented renderer processes from spawning--in-process-gpuand--enable-features=NetworkServiceInProcess2to avoid network service subprocess crasheswaitForAppReadyto force-show the main window in headless/VNC environmentsBefore: Only welcome-screen tests (no servers) passed in Cloud Agent VMs
After: 28+ tests pass including config, settings, menu bar, and downloads suites
Ticket Link
N/A - Environment documentation and CI compatibility improvement
Checklist
npm run lint:jsfor proper code formattingDevice Information
This PR was tested on: Cursor Cloud Agent VM (Ubuntu 24.04, x86_64, TigerVNC on :1)
Screenshots
Release Note