Skip to content

Improve title bar control button visibility#3819

Open
Anushka-chaurasia-prog wants to merge 1 commit into
mattermost:masterfrom
Anushka-chaurasia-prog:fix-window-control-visibility
Open

Improve title bar control button visibility#3819
Anushka-chaurasia-prog wants to merge 1 commit into
mattermost:masterfrom
Anushka-chaurasia-prog:fix-window-control-visibility

Conversation

@Anushka-chaurasia-prog
Copy link
Copy Markdown

@Anushka-chaurasia-prog Anushka-chaurasia-prog commented May 12, 2026

Summary

Improved the visibility of the title bar window control buttons by increasing the opacity of symbolColor in the title bar overlay configuration.

Changes Made

  • Updated symbolColor opacity from 0.64 to 0.9
  • Applied to both dark and light modes

Issue

The minimize, maximize, and close buttons were difficult to see against certain default theme backgrounds due to low contrast/opacity.

Change Impact: 🟢 Low

Regression Risk: Minimal. This is a purely visual change affecting window control button opacity in the title bar. The modification is isolated to a private method in a single file, involves only a constant value change (0.64 to 0.9), and has no behavioral or logical implications. No shared dependencies, core logic, or critical paths are affected.

QA Recommendation: Manual visual regression testing is recommended to verify that the window control buttons (minimize, maximize, close) are clearly visible and properly styled with the increased opacity in both dark and light theme modes. Automated testing coverage is low value given the trivial nature of the change.

Generated by CodeRabbitAI

Review Change Stack

@mm-cloud-bot
Copy link
Copy Markdown

@Anushka-chaurasia-prog: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

I understand the commands that are listed here

@mattermost-build
Copy link
Copy Markdown
Contributor

Hello @Anushka-chaurasia-prog,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 57a747aa-53df-4262-93af-7d46ae03ef67

📥 Commits

Reviewing files that changed from the base of the PR and between adfcd2c and 4606177.

📒 Files selected for processing (1)
  • src/app/windows/baseWindow.ts

📝 Walkthrough

Walkthrough

The title bar overlay symbol color opacity is increased from 0.64 to 0.9 in the getTitleBarOverlay() method to improve visibility, maintaining separate RGB values for dark and light mode selection.

Changes

Title bar overlay visibility

Layer / File(s) Summary
Title bar overlay symbol opacity
src/app/windows/baseWindow.ts
The getTitleBarOverlay() method increases the overlay symbolColor opacity from 0.64 to 0.9 for improved visibility in both dark and light modes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly summarizes the main change: improving visibility of title bar control buttons by increasing symbol color opacity from 0.64 to 0.9.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@devinbinnie
Copy link
Copy Markdown
Member

@Anushka-chaurasia-prog Thanks for the PR! Would you be open to posting a before and after screenshot for us so we can see what the change looks like? I'm going to ask our UX team to weigh in here and that would be easiest for them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants