This repository was archived by the owner on Jan 2, 2018. It is now read-only.
Charts with axis_labels do not display in gmail#28
Open
peterkovacs wants to merge 1 commit into
Open
Conversation
In order to properly handle escaping | for gmail, use URI.escape in jstize.
|
Was this checked in? I see issue #27 (which is the same as this issue) in the code's comments: |
Contributor
Author
|
As far as I know it was never merged. Edited: Ah, i screwed up when I made the issue. so I created this one to include the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displaying a chart in Gmail does not work with the current jstize function. It seems that Gmail chokes on unescaped | (pipe) characters for a labelled line chart, prefering the URL-encoded version. If jstize is replaced with URI.escape, then the chart renders correctly in Gmail.
The discussion for 9b5cfb9 makes it seem like this is intentional. However, URI.escape does not seem to break the display of any of the other example charts listed on http://googlecharts.rubyforge.org/