This repository was archived by the owner on Jan 2, 2018. It is now read-only.
Automatic min max#58
Open
dnagir wants to merge 2 commits into
Open
Conversation
…tter math at calculating those
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have had a lot of problems trying to get min-max values right especially with multiple (bar chart) series.
It turns out the API can do it automatically. But it was impossible to set it in the gem.
So this PR allows you to pass
:min_value => false, :max_value => falseto avoid explicitly setting those and rely on API to do that.Ideally I think it should be the default with the current behaviour enabled by setting both min and max values to
true.