ISSN hyperlink#5
Open
Edinbro wants to merge 5 commits into
Open
Conversation
Owner
|
This is mainly because of changes in the white spaces (space, new line, tab, etc.). If you ignore them, there is really not much: Since there is also a character which is badly encoded in your version, I assume this is because you modified the files with a tool which does a bad job, especially with no management of UTF8 characters. It might be you edited the files with an editor in Microsoft Windows, which may have make a mess of the newline characters, thus making a mess of the whole file. If you understand what I mean, I would be glad that you fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sorry for the 1,307 additions and 1,305 deletions, but the code should work, I tried on a couple of my projects. I haven't tried to find a solution though for the case that there is a comma between two or more ISSNs.
Cheers,
Frederic