Repository navigation
fix(completion): compile the dumpfile's .zwc atomically - #53
Open
edjeffreys wants to merge 1 commit into
Open
edjeffreys wants to merge 1 commit into
edjeffreys wants to merge 1 commit into
Conversation
- zrecompile writes the .zwc in place, so shells starting together read each other's half-written file: "zrecompile:zcompile:99 invalid zwc file" - compile to a per-shell temp .zwc and rename it over, like compdump does - test the compile, the stale recompile, and 12 shells racing it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
edjeffreys
commented
Nov 11, 2026
| zephyr-compaudit-warn &! | ||
| fi | ||
|
|
||
| # Recompiles only if stale, and renames atomically, so concurrent shells are safe. |
Author
There was a problem hiding this comment.
This comment is incorrect; it does not rename atomically 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zrecompile writes the .zwc in place, so shells starting together read each other's half-written file: "zrecompile:zcompile:99 invalid zwc file"
Instead; compile to a per-shell temp .zwc and rename it over, like compdump does.
Also test the compile, the stale recompile, and 12 shells racing it