[AEP][medium] AEP-20260924-r3-REPO-F01: align the event log path - #331
Merged
Merged
Conversation
The default logger path was chelation_debug.jsonl while the dashboard reads chelation_events.jsonl. Mixed ISO and missing timestamps no longer raise while sorting the events list.
mattmre
force-pushed
the
aep/medium/AEP-20260924-r3-REPO-F01/event-log
branch
from
September 24, 2026 15:24
a912f99 to
b3f3f9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The engine logger writes
chelation_events.jsonlwhen no path is passed, which is the file the dashboard reads.filter_eventssorts numbers as numbers and naive ISO timestamps as UTC. Unparseable stamps sort as 0 and the stored field is not rewritten.This score is for
b3f3f9b, replayed onto main after the dashboard stack.git range-diffmarks it equal to the previously scoreda912f99.Type of Change
Testing
Parent re-ran
test_event_log_contract.py,TestFilterEvents, andtest_chelation_logger.py: 39 passed. Ruff passed. Reviewgrok-tierb-331b-20260924confirmed the replay still has_event_sort_value,_limit_or_default, and the HTML-before-bearer branch.Brutal Honesty
summarize_eventsstill takes min and max of the raw timestamp values.+0000offset without a colon sorts as 0 and does not raise.a912f99. This score is forb3f3f9b.EVIDENCE: 39 logger and filter tests passed on b3f3f9b; range-diff equal to a912f99; review grok-tierb-331b-20260924
SMOKE: targeted unittest only; bash scripts/smoke.sh was not run on this branch
BHS_SELF_DRAFT: 100
BHS_SELF_DRAFT_AGENT: grok-aep-fix-20260924
BHS_TIER_B: 100
BHS_TIER_B_AGENT: grok-tierb-331b-20260924
BHS_TIER_B_SEVERITY: none
BHS_OFFICIAL: 100
CARRY_FORWARD: none
DEFERRED_SCOPE: none
LOOP_ITERATIONS: 2
OPERATOR_OVERRIDE: none